Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Able to search without prefix "0x" #1815

Merged
merged 4 commits into from
Apr 24, 2019
Merged

Able to search without prefix "0x" #1815

merged 4 commits into from
Apr 24, 2019

Conversation

saneery
Copy link
Contributor

@saneery saneery commented Apr 23, 2019

Resolves #1580

@ghost ghost assigned saneery Apr 23, 2019
@ghost ghost added the in progress label Apr 23, 2019
@saneery saneery added the ready for review This PR is ready for reviews. label Apr 23, 2019
@coveralls
Copy link

coveralls commented Apr 23, 2019 •
edited

Pull Request Test Coverage Report for Build 04399556-95eb-42b1-973f-babc9f41fde3

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.2%) to 79.027%
Totals Coverage Status
Change from base Build a78c3a59-56e2-486f-b6c4-ad53fa4e8bff: -3.2%
Covered Lines: 4273
Relevant Lines: 5407
💛 - Coveralls

goodsoft
goodsoft approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@goodsoft goodsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @vbaranov, otherwise looks good

@saneery
Copy link
Contributor Author

saneery commented Apr 24, 2019

@vbaranov I updated the PR, can we merge it?

@vbaranov
Copy link
Member

I updated the PR, can we merge it?

Yes, I will do. Thank you!

@vbaranov vbaranov self-requested a review April 24, 2019 08:16
@vbaranov vbaranov merged commit b87ec4a into master Apr 24, 2019
@ghost ghost removed the in progress label Apr 24, 2019
@vbaranov vbaranov deleted the search_without_prefix branch April 24, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

Assignees

@saneery saneery

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to search without 0x prefix
6 participants
@saneery @coveralls @vbaranov @goodsoft @zachdaniel @ayrat555