Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consolidate address w/ balance one at a time #1989

Merged
merged 2 commits into from
May 22, 2019

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented May 20, 2019

Changelog

Bug Fixes

  • Start consolidating in a handle_continue/2 hook instead of a task that is kicked off in the init callback.
  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

I checked the box here, but I can't reproduce whatever is causing the queries to stack up. However, spawning a task from the init like that is suspect, and isn't how that would normally be done.

@zachdaniel zachdaniel force-pushed the consolidate-only-once-at-a-time branch from 862d802 to 0a32431 Compare May 20, 2019 20:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2eb2f78a-f1e0-442d-907b-117eb6b2796e

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 81.137%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/counters/addresses_with_balance_counter.ex 1 4 25.0%
Totals Coverage Status
Change from base Build 70545e59-7263-4445-891c-7334f0e4d2a2: 0.03%
Covered Lines: 4710
Relevant Lines: 5805

💛 - Coveralls

vbaranov added a commit that referenced this pull request May 21, 2019
vbaranov added a commit that referenced this pull request May 22, 2019
@vbaranov vbaranov merged commit 042eb3a into master May 22, 2019
@vbaranov vbaranov deleted the consolidate-only-once-at-a-time branch May 22, 2019 13:17
vbaranov pushed a commit that referenced this pull request May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants