Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add address logs search functionality #2037

Merged
merged 30 commits into from
May 30, 2019
Merged

add address logs search functionality #2037

merged 30 commits into from
May 30, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented May 27, 2019 •
edited

fixes #1927

img1
img2

Changelog

  • add address logs search functionality

should be merged after #2012

@coveralls
Copy link

coveralls commented May 27, 2019 •
edited

Pull Request Test Coverage Report for Build 8cedce81-1039-4b9b-bef0-e10c19126e97

  • 3 of 16 (18.75%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.774%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/router.ex 0 1 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/address_logs_controller.ex 0 12 0.0%
Totals Coverage Status
Change from base Build 310a107e-df33-4f13-b380-37d8fda51b12: 0.0%
Covered Lines: 4777
Relevant Lines: 5914
💛 - Coveralls

@ayrat555 ayrat555 changed the title [WIP] add endpoint to search address logs by topic add adress logs search functionality May 28, 2019
@ayrat555 ayrat555 changed the title add adress logs search functionality add endpoint to search address logs by topic May 28, 2019
@ayrat555 ayrat555 changed the title add endpoint to search address logs by topic add address logs search functionality May 28, 2019
zachdaniel
zachdaniel approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@zachdaniel zachdaniel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the best judge of the js, but everything LGTM. There are failing lint/dialyzer/credo checks to deal with, but other than that 👍

@maxgrapps maxgrapps mentioned this pull request May 29, 2019
Merged
@vbaranov vbaranov self-requested a review May 30, 2019 09:38
vbaranov
vbaranov requested changes May 30, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555

  1. Search by topic doesn't work without 0x prefix
  2. If I am on other than 1st page in pagination, the search doesn't work

An example, where you can test it /address/0x96313f2c374f901e3831ea6de67b1165c4f39a54/logs

@maxgrapps

  1. The length of search field is dynamic https://www.loom.com/share/74b41dc9d843453ca89a97b5d5fabbb6

@ayrat555
Copy link
Contributor Author

@vbaranov I addressed your comments

@vbaranov vbaranov self-requested a review May 30, 2019 14:51
vbaranov
vbaranov approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbaranov vbaranov merged commit 140a4d2 into master May 30, 2019
@vbaranov vbaranov deleted the ab-logs-search-button branch May 30, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add smart contract event logs on the contract details page
6 participants
@ayrat555 @coveralls @vbaranov @zachdaniel @pasqu4le @maxgrapps