-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add address logs search functionality #2037
Conversation
Pull Request Test Coverage Report for Build 8cedce81-1039-4b9b-bef0-e10c19126e97
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the best judge of the js, but everything LGTM. There are failing lint/dialyzer/credo checks to deal with, but other than that 👍
apps/block_scout_web/lib/block_scout_web/templates/address_logs/index.html.eex
Show resolved
Hide resolved
…blockscout into ab-logs-search-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Search by topic doesn't work without
0x
prefix - If I am on other than 1st page in pagination, the search doesn't work
An example, where you can test it /address/0x96313f2c374f901e3831ea6de67b1165c4f39a54/logs
- The length of search field is dynamic https://www.loom.com/share/74b41dc9d843453ca89a97b5d5fabbb6
@vbaranov I addressed your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #1927
Changelog
should be merged after #2012