Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip for more button, explorers logos added #2081

Merged
merged 10 commits into from
Jun 3, 2019
Merged

Tooltip for more button, explorers logos added #2081

merged 10 commits into from
Jun 3, 2019

Conversation

maxgrapps
Copy link
Contributor

@maxgrapps maxgrapps commented Jun 2, 2019

Added tooltip "Explorers" for more button
Screen Shot 2019-06-03 at 01 27 42

Added logos for different explorers by css
Screen Shot 2019-06-03 at 01 27 47

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxgrapps please update your branch with upstream from master branch. You are trying to make a lot of unnecessary changes in CHANGELOG.md file

@@ -51,7 +51,7 @@
</span>
</div>
<!-- Verify in other explorers -->
<%# <%= render BlockScoutWeb.AddressView, "_verify_other_explorers.html", hash: hash(@transaction), type: "tx" %> %>
<%= render BlockScoutWeb.AddressView, "_verify_other_explorers.html", hash: hash(@transaction), type: "tx" %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is disabled by default in master

@maxgrapps
Copy link
Contributor Author

@vbaranov updated apps/block_scout_web/lib/block_scout_web/templates/transaction/overview.html.eex

@vbaranov vbaranov self-requested a review June 3, 2019 15:27
@vbaranov vbaranov merged commit 76ac452 into blockscout:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants