Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix large number in balance view card #2164

Merged
merged 5 commits into from
Jun 17, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jun 13, 2019

fixes #2163

Motivation

Before

before

After

after

Changelog

  • fix large number in balance view card

@coveralls
Copy link

coveralls commented Jun 13, 2019

Pull Request Test Coverage Report for Build d292a65c-c51a-478e-a600-4b62888e5534

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.4%) to 80.412%

Files with Coverage Reduction New Missed Lines %
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/case/parity/http_websocket.ex 1 0.0%
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/transform/addresses.ex 2 75.0%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/fetcher/contract_code.ex 3 71.88%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/web_socket/case/parity.ex 4 0.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/web_socket/web_socket_client.ex 6 76.25%
apps/indexer/lib/indexer/block/fetcher.ex 6 84.0%
Totals Coverage Status
Change from base Build a0cff3f8-8acb-40ec-9dcd-9a8a7217d873: -0.4%
Covered Lines: 4885
Relevant Lines: 6075

💛 - Coveralls

vbaranov added a commit that referenced this pull request Jun 13, 2019
@vbaranov vbaranov merged commit 0fffc42 into master Jun 17, 2019
@vbaranov vbaranov deleted the ab-fix-large-numbers-balance branch June 17, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NaN USD
6 participants