Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix interpolation in error message #2299

Merged
merged 3 commits into from
Jul 5, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 4, 2019

fixes

** (Protocol.UndefinedError) protocol String.Chars not implemented for %{"error" => %{"code" => -32601, "data" => nil, "message" => "Cannot find ommer for hash: 0x1251a9f1416c95e8f08a26422459202abbbfe71cdd9d90d3605d0711b6a4f78f"}, "id" => "0x0", "jsonrpc" => "2.0", "result" => nil}. This protocol is implemented for: Explorer.Chain.Address, Explorer.Chain.Data, Explorer.Chain.Hash, Postgrex.Copy, Postgrex.Query, Cldr.Unit, Decimal, Float, DateTime, Time, List, Version.Requirement, Atom, Integer, Version, Date, BitString, NaiveDateTime, URI
    (elixir) /private/tmp/elixir-20190202-21222-1ilp2g0/elixir-1.8.1/lib/elixir/lib/string/chars.ex:3: String.Chars.impl_for!/1
    (elixir) /private/tmp/elixir-20190202-21222-1ilp2g0/elixir-1.8.1/lib/elixir/lib/string/chars.ex:22: String.Chars.to_string/1
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/http.ex:144: EthereumJSONRPC.HTTP.standardize_response/1
    (elixir) lib/enum.ex:1327: Enum."-map/2-lists^map/1-0-"/2
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/http.ex:44: EthereumJSONRPC.HTTP.chunked_json_rpc/3
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/request_coordinator.ex:86: anonymous fn/3 in EthereumJSONRPC.RequestCoordinator.perform/4
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/request_coordinator.ex:106: EthereumJSONRPC.RequestCoordinator.trace_request/2
    (ethereum_jsonrpc) lib/ethereum_jsonrpc.ex:453: EthereumJSONRPC.fetch_blocks_by_params/3
    (indexer) lib/indexer/fetcher/uncle_block.ex:83: Indexer.Fetcher.UncleBlock.run/2
    (elixir) lib/task/supervised.ex:90: Task.Supervised.invoke_mfa/2
    (elixir) lib/task/supervised.ex:35: Task.Supervised.reply/5
    (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3

Changelog

  • fix interpolation in error message

@coveralls
Copy link

coveralls commented Jul 4, 2019

Pull Request Test Coverage Report for Build 6d587576-8ecd-4105-843d-05972111379b

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 80.993%

Totals Coverage Status
Change from base Build fe1dc346-7896-4f63-8605-2eb5791b2ef8: 0.04%
Covered Lines: 5156
Relevant Lines: 6366

💛 - Coveralls

@vbaranov vbaranov merged commit ab0c48e into master Jul 5, 2019
@vbaranov vbaranov deleted the ab-fix-error-interpolation branch July 5, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants