Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch rewards in parallel with transactions #2352

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Fetch rewards in parallel with transactions #2352

merged 1 commit into from
Jul 16, 2019

Conversation

pasqu4le
Copy link
Contributor

@pasqu4le pasqu4le commented Jul 12, 2019 •
edited
Loading

Part of #2306

Changelog

Enhancements

Part of the reason is that it has to execute 3 queries, but since 2 of these queries are unrelated to each other (transactions and rewards) they will be executed in parallel.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@pasqu4le pasqu4le self-assigned this Jul 12, 2019
@pasqu4le
Fetch rewards in parallel with transactions
a8823ab 
Problem: the Address main page is too slow. Part of the reason is that it has to execute 3 queries.

Solution: since 2 of these queries are unrelated to each other (transactions and rewards) they will be executed in parallel.
@pasqu4le pasqu4le force-pushed the pp-fetch-rewards-in-parallel-with-transactions branch from 8c33abf to a8823ab Compare July 12, 2019 14:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build e5d36f61-6986-4547-9192-bea61be4c7a0

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 80.93%
Totals Coverage Status
Change from base Build 1da3a2f7-0910-4e90-b68d-15e8c5a80423: 0.006%
Covered Lines: 5203
Relevant Lines: 6429
💛 - Coveralls

@pasqu4le pasqu4le added ready for review This PR is ready for reviews. and removed in progress labels Jul 12, 2019
vbaranov
vbaranov approved these changes Jul 16, 2019 •
edited
Loading
View reviewed changes
@vbaranov vbaranov merged commit 98b6829 into master Jul 16, 2019
@vbaranov vbaranov deleted the pp-fetch-rewards-in-parallel-with-transactions branch July 16, 2019 10:29
@ayrat555 ayrat555 mentioned this pull request Aug 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery saneery approved these changes

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees

@pasqu4le pasqu4le

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pasqu4le @coveralls @vbaranov @ayrat555 @saneery