Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase reward task timeout #2502

Merged
merged 6 commits into from
Aug 6, 2019
Merged

increase reward task timeout #2502

merged 6 commits into from
Aug 6, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Aug 5, 2019

Motivation

in this PR (#2352) we started fetching rewards for address transactions async. The default timeout for tasks is 5s. So the task is failing if it can not be finished in 5 seconds

For example,
https://blockscout.com/poa/core/address/0xeca443e8e1ab29971a45a9c57a6a9875701698a5/transactions

Request: GET /address/0x548806f2215f44571431292f2314480c3f519044/transactions?type=JSON
** (exit) exited in: Task.await(%Task{owner: #PID<0.31196.125>, pid: #PID<0.31219.125>, ref: #Reference<0.2013515151.3130261506.163217>}, 5000)
    ** (EXIT) time out

Changelog

  • increase reward task timeout

@coveralls
Copy link

coveralls commented Aug 5, 2019

Pull Request Test Coverage Report for Build 87caf976-85a3-42f2-8514-d278712c912f

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 79.383%

Totals Coverage Status
Change from base Build 1806de47-e9a9-4846-8359-5e17fec6f30e: 0.09%
Covered Lines: 5171
Relevant Lines: 6514

💛 - Coveralls

Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I had no idea there was this issue.

I only have the suggestion of using :timer

apps/explorer/lib/explorer/chain.ex Outdated Show resolved Hide resolved
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except Pasquale's comment I have no objections.

@vbaranov vbaranov merged commit 2ed9d88 into master Aug 6, 2019
@vbaranov vbaranov deleted the ab-increase-rewards-timeout branch August 6, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants