remove rewards from getminedblocks rpc response #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reward calculation is a heavy operation since it joins `rewards` and `transactions` tables with `blocks`. `transactions` is one of the largest tables in the DB. So that was a reason for a request timeout. Removing rewards fixed the issue. From this point rewards should be fetched with `getblockreward` rpc.
vbaranov
approved these changes
Aug 24, 2019
Pull Request Test Coverage Report for Build 5486ed8f-4eeb-45fc-b5ec-e5297e35e57b
💛 - Coveralls |
saneery
approved these changes
Aug 26, 2019
pasqu4le
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2493
Reward calculation is a heavy operation since it joins
rewardsandtransactionstables withblocks.transactionsis one of the largest tables in the DB.So that was a reason for a request timeout. Removing rewards
fixed the issue. From this point rewards should be fetched
with
getblockrewardrpc.Pagination is already implemented.
Changelog