-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix fetching latin1
encoded data
#2779
Conversation
some json contain latin1 encoded data which fails to be decoded
Pull Request Test Coverage Report for Build 9bd16b64-3085-45a3-8e2e-00088e7335b9
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see messages like this in error.log
:
2019-10-15T17:43:28.593 application=indexer fetcher=token_instances [error] failed to fetch token instance metadata for {"0xbd13e53255ef917da7557db1b7d2d5c38a2efe24", 788042363036}: {:error, ""}
@vbaranov the issue was in log level. it's fixed now |
@ayrat555 CHANGELOG entry is missing |
@vbaranov I added a CHANGELOG entry |
CHANGELOG.md
Outdated
@@ -18,6 +18,8 @@ | |||
- [#2470](https://github.com/poanetwork/blockscout/pull/2470) - Allow Realtime Fetcher to wait for small skips | |||
|
|||
### Fixes | |||
- [#2779](https://github.com/poanetwork/blockscout/pull/2779) - fix fetching `latin1` encoded data | |||
- [#2755](https://github.com/poanetwork/blockscout/pull/2755) - various token instance fetcher fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayrat555 it is a duplicate
Motivation
some JSONs contain latin1 encoded data which
fails to be decoded
Changelog
latin1
encoded data