Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fetching latin1 encoded data #2779

Merged
merged 9 commits into from
Oct 21, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Oct 15, 2019

Motivation

some JSONs contain latin1 encoded data which
fails to be decoded

Changelog

  • fix fetching latin1 encoded data
  • process json file in token uri
  • separate file for token instances logs

some json contain latin1 encoded data which
fails to be decoded
@coveralls
Copy link

coveralls commented Oct 15, 2019

Pull Request Test Coverage Report for Build 9bd16b64-3085-45a3-8e2e-00088e7335b9

  • 8 of 15 (53.33%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 76.999%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/indexer/lib/indexer/fetcher/token_instance.ex 0 1 0.0%
apps/explorer/lib/explorer/token/instance_metadata_retriever.ex 8 14 57.14%
Files with Coverage Reduction New Missed Lines %
apps/explorer/test/support/factory.ex 1 92.97%
Totals Coverage Status
Change from base Build 60978aa7-e1f4-495a-a1b3-0569471b6af3: 0.3%
Covered Lines: 5296
Relevant Lines: 6878

💛 - Coveralls

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555

I still see messages like this in error.log:

2019-10-15T17:43:28.593 application=indexer fetcher=token_instances [error] failed to fetch token instance metadata for {"0xbd13e53255ef917da7557db1b7d2d5c38a2efe24", 788042363036}: {:error, ""}

@ayrat555
Copy link
Contributor Author

@vbaranov the issue was in log level. it's fixed now

@vbaranov vbaranov self-requested a review October 21, 2019 11:03
@vbaranov
Copy link
Member

@ayrat555 CHANGELOG entry is missing

@ayrat555
Copy link
Contributor Author

@vbaranov I added a CHANGELOG entry

CHANGELOG.md Outdated
@@ -18,6 +18,8 @@
- [#2470](https://github.com/poanetwork/blockscout/pull/2470) - Allow Realtime Fetcher to wait for small skips

### Fixes
- [#2779](https://github.com/poanetwork/blockscout/pull/2779) - fix fetching `latin1` encoded data
- [#2755](https://github.com/poanetwork/blockscout/pull/2755) - various token instance fetcher fixes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 it is a duplicate

@vbaranov vbaranov merged commit 7315441 into master Oct 21, 2019
@vbaranov vbaranov deleted the ab-fix-token-instance-issues branch October 21, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants