-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async fetching of address counters #2787
Conversation
Pull Request Test Coverage Report for Build 420b0519-6ff0-4067-bd77-e560989dd3d9
💛 - Coveralls |
render( | ||
conn, | ||
"index.html", | ||
address: address, | ||
coin_balance_status: CoinBalanceOnDemand.trigger_fetch(address), | ||
exchange_rate: Market.get_exchange_rate(Explorer.coin()) || Token.null(), | ||
transaction_count: transaction_count, | ||
validation_count: validation_count | ||
counters_path: address_path(conn, :address_counters, %{"id" => to_string(address_hash)}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't to_string(address_hash)
the same as the input address_hash_string
?
If I counted correctly the same is valid in 9 other places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right. I changed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayrat555 after a long wait on the page of one of the validators.
/address/0x829bd824b016326a401d083b33d092293333a830/transactions
Actually, it has a lot of blocks validations and transactions
@vbaranov this thing happens because the async request for counters took too long. The values will be correct when the request finishes |
@ayrat555 please resolve merging conflicts |
@vbaranov done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayrat555 approved
I slightly modified PR by removing unnecessary padding when tx count is not retrieved yet
Please do not remove this branch if you will merge this PR.
Changelog