Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always redirect to checksummed hash #2834

Merged
merged 17 commits into from
Feb 7, 2020
Merged

always redirect to checksummed hash #2834

merged 17 commits into from
Feb 7, 2020

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Nov 4, 2019

resolves #2833

Changelog

  • always redirect to checksummed hash

@coveralls
Copy link

coveralls commented Nov 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 20bc12e1-f438-4eae-ac13-e726849473bd

  • 13 of 14 (92.86%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 75.388%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/checksum_address.ex 13 14 92.86%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/test/block_scout_web/features/pages/transaction_logs_page.ex 2 33.33%
Totals Coverage Status
Change from base Build 6b2cbfaf-78b9-40a2-a2bd-ad7c54621337: 0.006%
Covered Lines: 5437
Relevant Lines: 7212
💛 - Coveralls

@ayrat555 ayrat555 mentioned this pull request Nov 5, 2019
Merged
@vbaranov vbaranov merged commit 7784db8 into master Feb 7, 2020
@vbaranov vbaranov deleted the ab-add-checksum-plug branch February 7, 2020 10:44
This was referenced Feb 14, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@pasqu4le pasqu4le Awaiting requested review from pasqu4le

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix canonical URLs
3 participants
@ayrat555 @coveralls @vbaranov