Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksum address feature for tokens pages #3014

Merged
merged 2 commits into from
Feb 20, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Feb 19, 2020

Issue caused by #2834

Motivation

  • Some links on token/instances pages are broken
  • Checksummed address feature doesn't spread to token/instances pages

Changelog

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Feb 19, 2020
@coveralls
Copy link

coveralls commented Feb 19, 2020

Pull Request Test Coverage Report for Build f65c041b-3bb8-4f70-b89a-d3652ac6fc33

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 75.27%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/controllers/tokens/instance/transfer_controller.ex 0 1 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/tokens/transfer_controller.ex 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
Totals Coverage Status
Change from base Build 64e3f4f0-9d21-4c8c-86e1-46c9589b45a5: 0.05%
Covered Lines: 5436
Relevant Lines: 7222

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-fix-token-instance-page-display branch from ebf757f to 82d01b8 Compare February 19, 2020 14:23
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Feb 19, 2020
@vbaranov vbaranov merged commit 97a50f3 into master Feb 20, 2020
@vbaranov vbaranov deleted the vb-fix-token-instance-page-display branch February 20, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants