Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actualize Docker setup #2942

Merged
merged 3 commits into from
Jan 17, 2020
Merged

Actualize Docker setup #2942

merged 3 commits into from
Jan 17, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jan 9, 2020

Motivation

Actualize Docker setup with the latest set of ENV vars for Blockscout application

Changelog

  • add all supported environment variables to Makefile
  • increase the version of Elixir Docker image up to 1.9.1
  • increase the version of Postgres Docker image up to 10.10
  • add mix phx.digest command to Docker file in order to build front-end static assets
  • remove dropping of DB on the start of the container since it is not safe operation (ideally, it should be a separate command to drop database)

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Jan 9, 2020
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jan 9, 2020
@coveralls
Copy link

coveralls commented Jan 9, 2020

Pull Request Test Coverage Report for Build 8d38a414-89cc-48e2-9b29-e95b6b87c7e8

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 75.234%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build e57ca067-7f88-4266-a8e4-0de24447fcce: -0.01%
Covered Lines: 5377
Relevant Lines: 7147

💛 - Coveralls

@vbaranov vbaranov merged commit 4de3181 into master Jan 17, 2020
@vbaranov vbaranov deleted the vb-actualize-docker-setup branch January 17, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants