Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert realtime fetcher small skips feature #3011

Merged
merged 3 commits into from
Feb 19, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Feb 17, 2020

Reverts #2470

Motivation

This feature causes real time fetcher to skip blocks and catchup fetcher never processes them causing increasing the number of chain breaks. Noticed on Mainnet instance. In view of that fact and unclear profit from implementing of #2470 (it still tries to index indexed blocks), it is suggested to revert that PR.

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Feb 17, 2020
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Feb 17, 2020
@coveralls
Copy link

coveralls commented Feb 17, 2020

Pull Request Test Coverage Report for Build e16133fc-8bca-4acc-9885-6ead51faeda1

  • 3 of 16 (18.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 75.375%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 3 4 75.0%
apps/indexer/lib/indexer/block/realtime/fetcher.ex 0 12 0.0%
Totals Coverage Status
Change from base Build b2f4df0b-8a6e-490b-815f-3f3071320e57: -0.04%
Covered Lines: 5430
Relevant Lines: 7204

💛 - Coveralls

@vbaranov vbaranov merged commit d2ea212 into master Feb 19, 2020
@vbaranov vbaranov deleted the vb-revert-rt-fetcher-small-skips-feature branch February 19, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants