Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend optionality of websockets to Geth #3079

Merged
merged 2 commits into from
Apr 22, 2020

Conversation

vbaranov
Copy link
Member

Continuation of #2289 #1778

Motivation

Websockets are not optional for Geth

Changelog

Update Geth config

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Apr 22, 2020

Pull Request Test Coverage Report for Build 31e746f3-5a47-4f69-aa81-0a52b38c1223

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 74.957%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build e04a863f-2f6c-43a7-9dbe-aabe4e448e23: 0.07%
Covered Lines: 5612
Relevant Lines: 7487

💛 - Coveralls

@vbaranov vbaranov merged commit 0b47f9b into master Apr 22, 2020
@vbaranov vbaranov deleted the vb-optional-webosocket-for-geth branch April 22, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants