Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract verification: check compiler version, verify compiled with nightly builds #3112

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 15, 2020

#3110 #3111

Motivation

  • BlockScout doesn't check compiler version on verification
  • Contracts compiled with nightly builds cannot be verified

Checklist for your Pull Request (PR)

@vbaranov vbaranov added the wip label May 15, 2020
@vbaranov vbaranov self-assigned this May 15, 2020
@vbaranov vbaranov changed the title Verification: check compiler version Verification: check compiler version, verify compiled with nightly builds May 15, 2020
@vbaranov vbaranov changed the title Verification: check compiler version, verify compiled with nightly builds Conntract verification: check compiler version, verify compiled with nightly builds May 15, 2020
@vbaranov vbaranov changed the title Conntract verification: check compiler version, verify compiled with nightly builds Contract verification: check compiler version, verify compiled with nightly builds May 15, 2020
@coveralls
Copy link

coveralls commented May 15, 2020

Pull Request Test Coverage Report for Build 0b33e9f7-a890-4dc9-937f-1e6b226b71b1

  • 23 of 37 (62.16%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 75.099%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/smart_contract/verifier.ex 18 25 72.0%
apps/explorer/lib/explorer/smart_contract/verifier/constructor_arguments.ex 5 12 41.67%
Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/smart_contract/verifier/constructor_arguments.ex 2 83.7%
Totals Coverage Status
Change from base Build b482e664-71cc-4b94-8ee1-718bcc21083b: -0.1%
Covered Lines: 5706
Relevant Lines: 7598

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-verification-check-compiler branch from fe4d527 to 7af438b Compare May 15, 2020 13:15
@vbaranov vbaranov force-pushed the vb-verification-check-compiler branch from 7af438b to e1cdd75 Compare May 15, 2020 14:54
@vbaranov vbaranov removed the wip label May 15, 2020
@vbaranov vbaranov merged commit 9056a2b into vb-immutable-constant-verification-fix May 15, 2020
@vbaranov vbaranov deleted the vb-verification-check-compiler branch May 15, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants