Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revert reason message detection #3219

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Aug 3, 2020

Motivation

Revert reason is not shown for transactions at xDai instance
https://blockscout.com/poa/xdai/tx/0x4600d60565943c10b5486953a406de6e04612f62b2c590a16c4a72af9d658555/internal_transactions

Changelog

  • gas_price -> gasPrice in eth_call request
  • parse with "Reverted prefix"
  • decode message from response of eth_call

Checklist for your Pull Request (PR)

@github-actions
Copy link

github-actions bot commented Aug 3, 2020

Pull Request Test Coverage Report for Build ab0c4efc4da4ca0864679b39dc48830f9924b545-PR-3219

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-16.4%) to 55.682%

Totals Coverage Status
Change from base Build b20995a5e4a26761dcf772cd00e3d4fab5659f63: -16.4%
Covered Lines: 441
Relevant Lines: 792

💛 - Coveralls

@vbaranov vbaranov changed the title Fix revert reason detection Fix revert reason message detection Aug 3, 2020
@vbaranov vbaranov force-pushed the vb-fix-revert-reason-detection branch from ab0c4ef to c92d83c Compare August 3, 2020 10:06
@vbaranov vbaranov force-pushed the vb-fix-revert-reason-detection branch from c92d83c to 4910a49 Compare August 3, 2020 10:13
@vbaranov vbaranov merged commit 65e7ccb into master Aug 3, 2020
@vbaranov vbaranov deleted the vb-fix-revert-reason-detection branch August 3, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant