Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize token name definition, if name is empty #3431

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Nov 4, 2020

Closes #2536

Motivation

Standardize token name definition if there is no name:
"0x" + "left::binary-size(6)" + "-" + "right::binary-size(6)"

An example: 0x8a55f3-b3b9a5

Changelog

Screenshot 2020-11-04 at 23 46 51

Checklist for your Pull Request (PR)

@vbaranov vbaranov changed the title Standardize token name definition Standardize token name definition, if name is empty Nov 4, 2020
@coveralls
Copy link

coveralls commented Nov 4, 2020

Pull Request Test Coverage Report for Build 5a4e912adeafd40cc6a4153257393d8753549ffa-PR-3431

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.4%) to 67.586%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/views/address_view.ex 9 81.61%
Totals Coverage Status
Change from base Build f92bab912b2ee45260990a6781a8111d381cd34f: 2.4%
Covered Lines: 2058
Relevant Lines: 3045

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-token-name-fix branch 6 times, most recently from a482f5f to 37e8b8f Compare November 5, 2020 07:56
@vbaranov vbaranov merged commit c026f74 into master Nov 5, 2020
@vbaranov vbaranov deleted the vb-token-name-fix branch November 5, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary short address on token -> transfer page
2 participants