Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when loading the Staking DApp it makes an async call (request) to load items several times because of duplicated
firstPageLoad
calls inapps/block_scout_web/assets/js/lib/async_listing_load.js
. This PR adds an ability to not call thefirstPageLoad
when we don't need it. It can be turned on by a separate HTML attributedata-no-first-loading
in adiv
withdata-async-load
attr for any module. This PR turns this on only for thestaking
module.Without this PR we observe the pool list disappearing when using any tab within the Staking DApp UI because of the excess calls. They visually disappear until the next block arrives.
I think this also relates to other modules but propose to optimize it in separate PRs by removing excess requests when using the
async_listing_load.js
.Checklist for your Pull Request (PR)
CHANGELOG.md
with this PRmaster
in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.