Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow brackets for arrays for contract input data, fix decoding for multiple inputs #3513

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Dec 7, 2020

#3486

Motivation

  1. https://gitter.im/poanetwork/blockscout?at=5fcdf6f567bf4438e12d0a52 internal server error when calling a method with multiple inputs

  2. Square brackets are not allowed for an array input type. In order to provide the same experience for Remix users, it is suggested to allow square brackets.

Changelog

  1. Fix input data processing
  2. Allow square brackets for an array input type

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Dec 7, 2020

Pull Request Test Coverage Report for Build 4c3f9b3de404b97738c4dc812c24c8ae0f2d3af4-PR-3513

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.08%) to 66.828%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
lib/block_scout_web/checksum_address.ex 6 55.56%
Totals Coverage Status
Change from base Build 2bcf1ceaad28781617445ee9f0e2f13c2f6f54cc: -1.08%
Covered Lines: 2065
Relevant Lines: 3090

💛 - Coveralls

@vbaranov vbaranov merged commit 19c744f into master Dec 7, 2020
@vbaranov vbaranov deleted the vb-fix-multiple-input branch December 7, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants