Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract interaction: fix nested tuples in the output view, add formatting #3592

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jan 29, 2021

Motivation

Nested tuple outputs cause 500 server error.

Changelog

  • Process method call output recursively
  • Add formatting of nested output types

Screenshot 2021-02-01 at 01 42 23

Checklist for your Pull Request (PR)

@vbaranov vbaranov marked this pull request as draft January 29, 2021 17:12
@vbaranov vbaranov changed the title Contract interaction: fix nested outputs view Contract interaction: fix nested tuples in the output view Jan 29, 2021
@coveralls
Copy link

coveralls commented Jan 29, 2021

Pull Request Test Coverage Report for Build c32287293faf63bb32592328c02525a876887bc0-PR-3592

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 62 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+3.2%) to 65.429%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/checksum_address.ex 6 55.56%
lib/block_scout_web/views/smart_contract_view.ex 56 36.67%
Totals Coverage Status
Change from base Build aff90fbd651751d4347cb74dc212f97a16af8bf4: 3.2%
Covered Lines: 2080
Relevant Lines: 3179

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-nested-types-fix branch 2 times, most recently from f94e1a6 to 49ed013 Compare January 31, 2021 23:07
@vbaranov vbaranov changed the title Contract interaction: fix nested tuples in the output view Contract interaction: fix nested tuples in the output view, add formatting Feb 1, 2021
@vbaranov vbaranov force-pushed the vb-nested-types-fix branch 3 times, most recently from 7bf1f93 to 3893df9 Compare February 1, 2021 17:01
@vbaranov vbaranov marked this pull request as ready for review February 1, 2021 18:16
@vbaranov vbaranov merged commit f9b34d2 into master Feb 1, 2021
@vbaranov vbaranov deleted the vb-nested-types-fix branch February 1, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants