Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridged tokens price feed improvement #3707

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Mar 15, 2021

Motivation

Improve bridged tokens price feed

Changelog

Get the price of bridged tokens from a foreign token contract address, not from symbol

Chore:

  • CUSTOM_CONTRACT_ADDRESSES_TEST_TOKEN environment variable to manage test tokens and exclude them in the market cap of bridged tokens

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-bridged-tokens-fix branch 3 times, most recently from b706f53 to 736c2da Compare March 15, 2021 10:12
@coveralls
Copy link

coveralls commented Mar 15, 2021

Pull Request Test Coverage Report for Build d3a54d821b60eea8a90db1c4a58cfa1d424a24ca-PR-3707

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 64.455%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/checksum_address.ex 6 55.56%
Totals Coverage Status
Change from base Build 4ff75f8e5ff137786f0cf23381c47dbaf62db96e: -0.9%
Covered Lines: 2098
Relevant Lines: 3255

💛 - Coveralls

@vbaranov vbaranov merged commit e8db5b6 into master Mar 15, 2021
@vbaranov vbaranov deleted the vb-bridged-tokens-fix branch March 15, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants