Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug that sometimes lead to incorrect ordering of token transfers #3989

Merged
merged 1 commit into from
May 17, 2021

Conversation

patriksletmo
Copy link
Contributor

@patriksletmo patriksletmo commented May 10, 2021

Fixes #3988.

Changelog

Bug Fixes

  • Fixed bug that sometimes lead to incorrect ordering of token transfers

Checklist for your Pull Request (PR)

@patriksletmo patriksletmo changed the title Order token transfers after INNER JOIN Fixed bug that sometimes lead to incorrect ordering of token transfers May 10, 2021
@vbaranov vbaranov self-requested a review May 17, 2021 09:20
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will correct the tests in the next PR to fix this issue, that you also mentioned:

During testing I also found that the tests related to token transfer ordering are broken. The list of found token transfers appears to be empty

@vbaranov vbaranov merged commit f3b6d82 into blockscout:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requested ordering of token transfers is not respected
2 participants