-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for partially verified via sourcify contracts #4331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
14d0862
to
3160524
Compare
246c851
to
2aa6148
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks about the naming and method interface changing, test coverage in the code and:
.../block_scout_web/lib/block_scout_web/controllers/address_contract_verification_controller.ex
Outdated
Show resolved
Hide resolved
.../block_scout_web/lib/block_scout_web/controllers/address_contract_verification_controller.ex
Outdated
Show resolved
Hide resolved
apps/block_scout_web/lib/block_scout_web/controllers/api/rpc/contract_controller.ex
Outdated
Show resolved
Hide resolved
apps/block_scout_web/lib/block_scout_web/templates/address_contract/index.html.eex
Outdated
Show resolved
Hide resolved
apps/explorer/priv/repo/migrations/20210701084814_support_partial_match.exs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listcontracts
API endpoint with unverified
option returns verified in Sourcify contracts. It should return them with verified
option.
This works in fact |
fe245cb
to
c60efc2
Compare
c60efc2
to
a851195
Compare
Closes #4317
Changelog
Checklist for your Pull Request (PR)
CHANGELOG.md
with this PRmaster
in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.