Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for partially verified via sourcify contracts #4331

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Jul 1, 2021

Closes #4317

Changelog

  • If smart-contract verified via Sourcify Blockscout will fetch it automatically
  • Added support for partially verified contracts via Sourcify

Checklist for your Pull Request (PR)

Copy link

@mj5599-spo mj5599-spo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikitosing nikitosing marked this pull request as ready for review July 5, 2021 10:57
@nikitosing nikitosing changed the title Np add partial sourcify Add support for partially verified via sourcify contracts Jul 5, 2021
@nikitosing nikitosing force-pushed the np-add-partial-sourcify branch 6 times, most recently from 246c851 to 2aa6148 Compare July 6, 2021 09:36
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks about the naming and method interface changing, test coverage in the code and:

  1. Incorrect URL generated to Sourcify repository for partially verified contract: https://repo.sourcify.dev/contracts/full_match/partial_match/77/0xE300553919bEC8641eF110cbc9042b83b9f4b5a1/
  2. I know this is not a part of concrete this PR, but let's put "Verify & Publish" button above:
    Screenshot 2021-07-08 at 20 47

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listcontracts API endpoint with unverified option returns verified in Sourcify contracts. It should return them with verified option.

@vbaranov
Copy link
Member

vbaranov commented Jul 9, 2021

listcontracts API endpoint with unverified option returns verified in Sourcify contracts. It should return them with verified option.

This works in fact

@nikitosing nikitosing force-pushed the np-add-partial-sourcify branch 2 times, most recently from fe245cb to c60efc2 Compare July 9, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch contracts metadata for partially verified contracts in Sourcify
3 participants