Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token instance image display imrovement #5020

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Dec 19, 2021

Resolves #4935

Motivation

Eliminate error of kind:

Request: GET /token/0x906d56d114ef1bb430a1c450dc6b24df22d3e759/instance/22/token-transfers
** (exit) an exception was raised:
    ** (FunctionClauseError) no function clause matching in URI.encode/2
        (elixir 1.12.2) lib/uri.ex:366: URI.encode(["https://5cryptos.com/wp-content/uploads/2021/06/Shiba-Inu-Grain-NFT-004.png"], #Function<1.66049009/1 in URI."-fun.char_unescaped?/1-">)
        (block_scout_web 0.0.1) lib/block_scout_web/views/tokens/instance/overview_view.ex:159: BlockScoutWeb.Tokens.Instance.OverviewView.retrieve_image/2
        (block_scout_web 0.0.1) lib/block_scout_web/views/tokens/instance/overview_view.ex:34: BlockScoutWeb.Tokens.Instance.OverviewView.media_src/1
        (block_scout_web 0.0.1) lib/block_scout_web/templates/tokens/instance/overview/_details.html.eex:65: BlockScoutWeb.Tokens.Instance.OverviewView."_details.html"/1
        (block_scout_web 0.0.1) lib/block_scout_web/templates/tokens/instance/transfer/index.html.eex:2: BlockScoutWeb.Tokens.Instance.TransferView."index.html"/1
        (phoenix 1.5.13) lib/phoenix/view.ex:310: Phoenix.View.render_within/3
        (phoenix 1.5.13) lib/phoenix/view.ex:472: Phoenix.View.render_to_iodata/3
        (phoenix 1.5.13) lib/phoenix/controller.ex:777: Phoenix.Controller.render_and_send/4

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-token-instance-fix branch 2 times, most recently from b6826b5 to 26d8c6c Compare December 20, 2021 07:35
@vbaranov vbaranov merged commit de01b83 into master Dec 20, 2021
@vbaranov vbaranov deleted the vb-token-instance-fix branch December 20, 2021 08:26
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token instance token transfers page: no function clause matching in URI.encode/2
1 participant