Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of some redirects to checksummed address url #5625

Merged
merged 3 commits into from
May 31, 2022
Merged

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented May 30, 2022

Motivation

urls for fetching transaction (and other) pages returned by backend contains non checksummed address hash. It leads to redirect when clients fetch page and as the consequence larger waiting time

Changelog

Enhancements

  • change Phoenix.Param implementation. Now it returns checksummed address_hash for address

Checklist for your Pull Request (PR)

@nikitosing nikitosing changed the title Get rid of redirects to checksummed address url Get rid of some redirects to checksummed address url May 30, 2022
@nikitosing nikitosing requested a review from vbaranov May 30, 2022 15:40
@vbaranov vbaranov merged commit fbab757 into master May 31, 2022
@vbaranov vbaranov deleted the np-fix-redirects branch May 31, 2022 08:36
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Jun 6, 2022
Get rid of some redirects to checksummed address url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants