Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clause for 404 response from CoinGecko; Disable fetching btc_value by default #5671

Merged
merged 5 commits into from
Jun 16, 2022

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Jun 15, 2022

Close #5658
Close #5646
blockscout/docs#55

Changelog

  • handle 404 response from CoinGecko
  • add EXCHANGE_RATES_FETCH_BTC_VALUE env variable
  • add CACHE_EXCHANGE_RATES_PERIOD env variable

Checklist for your Pull Request (PR)

@nikitosing nikitosing changed the title Add clause for 404 response from CoinGecko Add clause for 404 response from CoinGecko; Disable fetching btc_value by default Jun 15, 2022
@nikitosing nikitosing force-pushed the np-fix-double-exchange-rates-request branch from f8dea69 to 2e0c46f Compare June 15, 2022 15:11
@nikitosing nikitosing force-pushed the np-fix-double-exchange-rates-request branch 2 times, most recently from bceca6c to 436ee40 Compare June 15, 2022 19:23
@nikitosing nikitosing requested a review from vbaranov June 15, 2022 20:27
@nikitosing nikitosing force-pushed the np-fix-double-exchange-rates-request branch from 436ee40 to 1e34c1c Compare June 15, 2022 20:50
@vbaranov vbaranov merged commit 3cae206 into master Jun 16, 2022
@vbaranov vbaranov deleted the np-fix-double-exchange-rates-request branch June 16, 2022 10:31
@vbaranov
Copy link
Member

@nikitosing After installing the update, there are still duplicate requests:

/api/v3/coins/ethereum/contract/0x69b0788ef7104d2029c8a34e30e157675ca939d1 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x69b0788ef7104d2029c8a34e30e157675ca939d1 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x9f393a20192761562b08c8d6175a90c8996419ca Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x7279e7a234feaaf8c5d2088eac3ab71ae80a9e77 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x67be1a7555a7d38d837f6587530ffc33d89f5a90 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x7279e7a234feaaf8c5d2088eac3ab71ae80a9e77 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xa24e8f12faae4799745213dabec43f7a7d9d2dd5 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xa24e8f12faae4799745213dabec43f7a7d9d2dd5 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x5f18c75abdae578b483e5f43f12a39cf75b973a9 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x9f393a20192761562b08c8d6175a90c8996419ca Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x5f18c75abdae578b483e5f43f12a39cf75b973a9 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x7249fd2b946caed7d6c695e1656434a063723926 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x67be1a7555a7d38d837f6587530ffc33d89f5a90 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x56021b1b327ebe1eed2182a74d5f6a9a04eb2c73 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x56021b1b327ebe1eed2182a74d5f6a9a04eb2c73 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x0bce608dce5b99aa7cd89de09447a33b347aa294 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x7249fd2b946caed7d6c695e1656434a063723926 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x0bce608dce5b99aa7cd89de09447a33b347aa294 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xe3dce982416cb44d0376923bda3dd92822ea5827 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xe3dce982416cb44d0376923bda3dd92822ea5827 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xfc2a0e600e71e8c2484c15a22c514d1f2d10879b Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xce222993a7e4818e0d12bc56376c5a60f92a5783 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x27fbdd15fb0820b50b9c3683ea628bb6ab9b2d70 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x68ecf706820ffe6686928a409d3bf4074d00c1eb Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xce222993a7e4818e0d12bc56376c5a60f92a5783 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xfc2a0e600e71e8c2484c15a22c514d1f2d10879b Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x27fbdd15fb0820b50b9c3683ea628bb6ab9b2d70 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x2adcbee886d23eff5adecc7767bf102e4a1ce151 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x5a731151d6510eb475cc7a0072200cffc9a3bfe5 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x5a731151d6510eb475cc7a0072200cffc9a3bfe5 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xbcbc902f650cd5c2b77e85d2b63a71a1963d7539 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x2adcbee886d23eff5adecc7767bf102e4a1ce151 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x68ecf706820ffe6686928a409d3bf4074d00c1eb Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xbcbc902f650cd5c2b77e85d2b63a71a1963d7539 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xc57a51780f7c1af20212bb9f8707152039f9630d Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xc57a51780f7c1af20212bb9f8707152039f9630d Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x27fd686db10e0ae047fe8fe1de9830c0e0dc3cfa Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xda9dd450d8d0b4bd89e3f036c49cb90f0a35e59a Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x27fd686db10e0ae047fe8fe1de9830c0e0dc3cfa Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xa6a21313fe2fc6a5cf1e293dcbf99d180865babc Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xda9dd450d8d0b4bd89e3f036c49cb90f0a35e59a Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x49519631b404e06ca79c9c7b0dc91648d86f08db Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xa6a21313fe2fc6a5cf1e293dcbf99d180865babc Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xd9153c72a6e1f6f362b13b6891b840e99ad46561 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x49519631b404e06ca79c9c7b0dc91648d86f08db Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xfcfc8eacc436f336a80c63a7cec03d9b04c62f25 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xd9153c72a6e1f6f362b13b6891b840e99ad46561 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xfcfc8eacc436f336a80c63a7cec03d9b04c62f25 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xd499209b6e6c7d5ff43fcec824bfac603a426861 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xc35e5d3618da78161c28845557ce9c622b922a76 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xe6f3465d86690a4595eadfcae74b5fb79e91ab70 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xc35e5d3618da78161c28845557ce9c622b922a76 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xe6f3465d86690a4595eadfcae74b5fb79e91ab70 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x144cc4644abfd8c4c879bd2996b732740ca976e1 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xd499209b6e6c7d5ff43fcec824bfac603a426861 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x144cc4644abfd8c4c879bd2996b732740ca976e1 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xa0df6890950f641ba05bc2edfb8b8d3057901bd1 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xa0df6890950f641ba05bc2edfb8b8d3057901bd1 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xf0d6ababf791d1eeb2371bc59642ca6cc10272b1 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x524d70f777c75ec50291bdd69718c1a705268c8b Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x524d70f777c75ec50291bdd69718c1a705268c8b Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xf0d6ababf791d1eeb2371bc59642ca6cc10272b1 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x74b8d4da798c7fc0f9c6eeb94d06a91352ebc5ed Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x74b8d4da798c7fc0f9c6eeb94d06a91352ebc5ed Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xc46a1691f151dddabb2e0f8a370ece40a6947025 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xf51d48b4554862604d3e69a424c2b68afe3bb968 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xddeb1a370a88c5bcb6ec10191c03f8ec1d2bd6fa Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xc46a1691f151dddabb2e0f8a370ece40a6947025 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xf51d48b4554862604d3e69a424c2b68afe3bb968 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xddeb1a370a88c5bcb6ec10191c03f8ec1d2bd6fa Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x9f65cfd011233c2193bfeb5088f0e86068b794b0 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x9f65cfd011233c2193bfeb5088f0e86068b794b0 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xc8c97d9b0af219c2329a0179f6ab8c7a55b39fc1 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xc8c97d9b0af219c2329a0179f6ab8c7a55b39fc1 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xd9c2f0ba5e64015ac6ea3b1bf4a2bd3d39000aab Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x358d12436080a01a16f711014610f8a4c2c2d233 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x358d12436080a01a16f711014610f8a4c2c2d233 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x8d6f9a1141821e8ef3a0fceffe6e912def66ef3e Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x8d6f9a1141821e8ef3a0fceffe6e912def66ef3e Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xd9c2f0ba5e64015ac6ea3b1bf4a2bd3d39000aab Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x950f40e389c577b8667f2f2151cf9a381463f384 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x950f40e389c577b8667f2f2151cf9a381463f384 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xef826da5aadae742ce32ce0c460f30ab281e51a2 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x6a126b1a4d6a66370930eca642eff93d8e1be321 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0xef826da5aadae742ce32ce0c460f30ab281e51a2 Monday, Jun 20, 2022, 00:29am
/api/v3/coins/ethereum/contract/0x6a126b1a4d6a66370930eca642eff93d8e1be321 Monday, Jun 20, 2022, 00:29am

sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Jun 22, 2022
…ange-rates-request

Add clause for 404 response from CoinGecko; Disable fetching btc_value by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants