Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate rust verifier micro-service #5860

Merged
merged 13 commits into from
Aug 15, 2022
Merged

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Aug 9, 2022

Close #5574
Close #5886

Changelog

  • add multi-part files verification
  • move verification logic to rust micro-service
  • add 2 ENV variables to manage integration:
export ENABLE_RUST_VERIFICATION_SERVICE=true
export RUST_VERIFICATION_SERVICE_URL=http://0.0.0.0:8043/

Checklist for your Pull Request (PR)

@nikitosing nikitosing changed the title Integrate rust verifier microserviced Integrate rust verifier microservice Aug 9, 2022
@nikitosing nikitosing force-pushed the np-integrate-rust-verifier branch 2 times, most recently from 6004bb3 to 946644e Compare August 10, 2022 10:21
@vbaranov
Copy link
Member

@nikitosing I've launched Rust microservice locally, set env variables in order to enable microservice integration in Blockscout:

export ENABLE_RUST_VERIFICATION_SERVICE=true
export RUST_VERIFICATION_SERVICE_URL=http://0.0.0.0:8043/

And the list of compiler versions is empty (I tested flattened source code verification):
Screenshot 2022-08-10 at 17 55 27

Whereas corresponding microservice endpoint works fine:
Screenshot 2022-08-10 at 17 57 57

@vbaranov
Copy link
Member

@nikitosing let's define env variables in runtime config instead of regular config in order to change them without recompiling?

@vbaranov
Copy link
Member

vbaranov commented Aug 10, 2022

@nikitosing when chosing multi-part verification, /verify-via-flattened-code/new path is opened. I suppose, this is the bug?

Fixed by running mix phx.digest

@nikitosing nikitosing changed the title Integrate rust verifier microservice Integrate rust verifier micro-service Aug 11, 2022
@vbaranov vbaranov merged commit 3e70470 into master Aug 15, 2022
@vbaranov vbaranov deleted the np-integrate-rust-verifier branch August 15, 2022 09:22
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vyper verification is broken Separate Contract Verification to a standalone micro-service
2 participants