-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV export filters #7363
Merged
Merged
CSV export filters #7363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0939080
to
b5bd034
Compare
2815e05
to
18437eb
Compare
9d9dad6
to
39f8d8a
Compare
39f8d8a
to
e994c29
Compare
nikitosing
reviewed
May 7, 2023
apps/explorer/lib/explorer/chain/csv_export/address_transaction_csv_exporter.ex
Show resolved
Hide resolved
nikitosing
reviewed
May 7, 2023
apps/explorer/lib/explorer/chain/csv_export/address_internal_transaction_csv_exporter.ex
Show resolved
Hide resolved
98cd8e5
to
df05688
Compare
.../block_scout_web/lib/block_scout_web/templates/common_components/_csv_export_button.html.eex
Outdated
Show resolved
Hide resolved
apps/block_scout_web/lib/block_scout_web/templates/csv_export/index.html.eex
Outdated
Show resolved
Hide resolved
apps/explorer/lib/explorer/chain/csv_export/address_token_transfer_csv_exporter.ex
Show resolved
Hide resolved
1f3c22b
to
f0b774e
Compare
nikitosing
approved these changes
May 31, 2023
77e5648
to
83ee1bd
Compare
sl1depengwyn
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6041
Motivation
Applied filters on the items list are not accounted while exporting data to CSV.
Changelog
Apply selected filters (by address: to/from/created contract or by log topic) to CSV export as well: transactions, token transfers, internal transactions and logs.
Checklist for your Pull Request (PR)
CHANGELOG.md
with this PRmaster
in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.