Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Profile.js fixed: data-index undefined #34

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

tw-94
Copy link
Contributor

@tw-94 tw-94 commented Aug 5, 2019

the function removeTask () sometimes returns an undefined value with data-index and deletes the wrong to-do line.

@moxiegirl moxiegirl requested a review from yknl August 5, 2019 21:18
@moxiegirl
Copy link
Contributor

Thank you @BurstNeon for the PR. We will do a test and merge this if it passes.

Copy link
Contributor

@yknl yknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moxiegirl moxiegirl merged commit 6f7e6ed into hirosystems:master Aug 29, 2019
@tw-94 tw-94 deleted the patch-1 branch August 29, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants