Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social verification for non .id names (.personal.id, .stealthy.id, etc) #446

Closed
0xpbj opened this issue Apr 26, 2018 · 9 comments
Closed
Labels
enhancement Iterations/refactor on existing features/infrastructure/tests

Comments

@0xpbj
Copy link

0xpbj commented Apr 26, 2018

I verified prabhaav.stealthy.id with twitter: https://twitter.com/rabhaav/status/989518691476717569

But the browser is not confirming it:

image

@liphan
Copy link

liphan commented May 11, 2018

same here, liphan.stealthy.id cannot be verified with
twitter: https://twitter.com/liphan_/status/994514853355184128
github: https://gist.github.com/liphan/5d22b0fefbef8a7988b677a88bab1a3d
can someone please advise ?

@0xpbj
Copy link
Author

0xpbj commented May 11, 2018

@yknl @kantai

@yknl
Copy link
Contributor

yknl commented Jul 6, 2018

The social proof validation library assumes that the format of the username is name.id and will throw an error if there are more than 2 parts. e.g. sponsored.name.id.

This line needs to be fixed: https://github.com/blockstack/blockstack.js/blob/master/src/profiles/services/serviceUtils.js#L9

@larrysalibra larrysalibra added this to To do in 18.0.0 Release via automation Jul 9, 2018
@larrysalibra larrysalibra added the enhancement Iterations/refactor on existing features/infrastructure/tests label Jul 9, 2018
@larrysalibra
Copy link
Contributor

Thanks @wbobeirne this will be in the next release.

18.0.0 Release automation moved this from To do to Done Jul 9, 2018
@blkmrktmatt
Copy link

still having issues here with name.id.blockstack - the error in console is:
Uncaught (in promise) Error: Please provide the fully qualified Blockstack name. at containsValidProofStatement (main.js:66562)

@yknl
Copy link
Contributor

yknl commented Aug 7, 2018

hey @blkmrktmatt can you confirm which version of the Browser you're using?

@blkmrktmatt
Copy link

I'm using the latest Blockstack-for-macOS-v0.30.1, strange thing though last night on my laptop hackernews and twitter showed both verified, today on my desktop both unverified

@yknl yknl reopened this Aug 7, 2018
@yknl
Copy link
Contributor

yknl commented Aug 7, 2018

This should be fixed when the browser upgrades to the latest version of blockstack.js
stacks-archive/blockstack-browser#1582

@yknl
Copy link
Contributor

yknl commented Aug 9, 2019

This should now be working with latest browser and blockstack.js versions.

@yknl yknl closed this as completed Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Iterations/refactor on existing features/infrastructure/tests
Projects
No open projects
Development

No branches or pull requests

6 participants