Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for subdomain proofs #490

Merged
merged 2 commits into from
Jul 9, 2018
Merged

Allow for subdomain proofs #490

merged 2 commits into from
Jul 9, 2018

Conversation

wbobeirne
Copy link
Contributor

Closes #446. Loosens the check against blockstack names to allow for subdomains. Adds a unit test to make sure this continues to work.

@wbobeirne wbobeirne requested a review from yknl July 6, 2018 18:42
@CLAassistant
Copy link

CLAassistant commented Jul 6, 2018 •
edited

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ wbobeirne
❌ larrysalibra
You have signed the CLA already but the status is still pending? Let us recheck it.

@wbobeirne wbobeirne changed the base branch from master to develop July 6, 2018 18:43
yknl
yknl approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@yknl yknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@larrysalibra larrysalibra self-requested a review July 9, 2018 00:23
larrysalibra
larrysalibra approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@larrysalibra larrysalibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly! Thanks @wbobeirne !

@larrysalibra larrysalibra added this to In progress in 18.0.0 Release via automation Jul 9, 2018
@larrysalibra larrysalibra self-assigned this Jul 9, 2018
@larrysalibra
Copy link
Contributor

@wbobeirne @yknl I added a change log entry for this improvement.

@larrysalibra larrysalibra merged commit 7eff8ad into develop Jul 9, 2018
18.0.0 Release automation moved this from In progress to Done Jul 9, 2018
@larrysalibra larrysalibra deleted the feature/fix-subdomain-proofs branch July 9, 2018 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larrysalibra larrysalibra larrysalibra approved these changes

@yknl yknl yknl approved these changes

Assignees

@larrysalibra larrysalibra

Labels
None yet
Projects
No open projects
18.0.0 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wbobeirne @CLAassistant @larrysalibra @yknl