Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an authentication flow that does not depend on window.location and window.localStorage #526

Closed
jcnelson opened this issue Aug 7, 2018 · 1 comment
Assignees
Labels
enhancement Iterations/refactor on existing features/infrastructure/tests

Comments

@jcnelson
Copy link
Collaborator

jcnelson commented Aug 7, 2018

This is related to #500, but the concern is more general than just storage. In addition to Node.js clients like the CLI, Web clients need to be able to run code from blockstack.js in web workers, which today means transferring this state from the browser into the web worker.

Is there a way the app can initiate a sign-in flow where all this state is passed as arguments and/or stored in a global variable in RAM? For example, could handlePendingSignin() be modified to take an alternative value for window.location and be instructed to populate a given object with the Gaia session data and transit keys? Asking because I'm not sure what the best approach is here (but happy to take a crack at it!)

@jcnelson jcnelson added the enhancement Iterations/refactor on existing features/infrastructure/tests label Aug 7, 2018
@jcnelson jcnelson self-assigned this Aug 7, 2018
@yknl
Copy link
Contributor

yknl commented Oct 10, 2019

The dependency on a browser environment has been removed since v18.0

@yknl yknl closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Iterations/refactor on existing features/infrastructure/tests
Projects
None yet
Development

No branches or pull requests

2 participants