Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getFile not rejecting the Promise #601

Closed
benoror opened this issue Jan 22, 2019 · 1 comment
Closed

getFile not rejecting the Promise #601

benoror opened this issue Jan 22, 2019 · 1 comment
Milestone
DevX 2019 Q3 Spri...

Comments

@benoror
Copy link

benoror commented Jan 22, 2019

Blockstack docs (18.2.0) states that getFile :

resolves to the raw data in the file or rejects with an error

Nevertheless in practice it does resolve the Promise and returns a null object instead, thus never getting into the .catch( statement.

Even the DEBUG log says it so:

[DEBUG] getFile my/file.json returned 404, returning null
benoror added a commit to Sundly/sundly that referenced this issue Jan 22, 2019
@benoror
Issue: getFile not rejecting the Promise
08caa2a 
hirosystems/stacks.js#601
@stackatron stackatron added this to the DX Q3 1 milestone Aug 7, 2019
@yknl yknl modified the milestones: DX Q3 Sprint 2, DX Q3 Sprint 3 Sep 16, 2019
@shreyasthiagaraj shreyasthiagaraj mentioned this issue Sep 25, 2019
Merged
@yknl
Copy link
Contributor

yknl commented Oct 10, 2019

getFile now returns a proper error #720

@yknl yknl closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DevX 2019 Q3 Sprint 3
Development

No branches or pull requests
3 participants
@benoror @stackatron @yknl