Replace deprecated 'prepublish' npm script to 'prepare'. Fixes #368 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
larrysalibra
approved these changes
May 24, 2018
There was a problem hiding this comment.
looks great to me! thank you for this @sarathms and sorry for taking so long to address it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npmhas deprecatedprepublishin favor ofprepareas per npm/npm#10074The build script can now be run as part of the maintainer's publishing chore
npm publish. Although it doesn't seem right that there are uncommitted changes in the working directory which need to be committed and pushed to the repo again.