Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to FAQ for words-length error message upon Secret Key entry #641

Closed
timstackblock opened this issue Feb 24, 2021 · 17 comments
Closed
Assignees
Labels
Enhancement 💡 Functionality needed or wanted by users

Comments

@timstackblock
Copy link

timstackblock commented Feb 24, 2021

SCENARIO 1

- If you have a Trezor with a 12 word or 24 word seed phrase you can easily use the same seed phrase in the old wallet (via your trezor) and in the new wallet by entering the seed phrase into the seed phrase input box.

- Below you see me entering the 12 word seed phrase from my Trezor into the new v4 wallet and it opening to the same address that I get when accessing the v3 wallet with my Trezor.

- There is absolutely no issue and the migration from the old wallet to the new wallet is seamless.

Screen Shot 2021-02-25 at 12 25 25 PM

Screen Shot 2021-02-25 at 11 36 04 AM

Screen Shot 2021-02-25 at 11 36 22 AM

Screen Shot 2021-02-25 at 11 48 41 AM

Screen Shot 2021-02-25 at 11 48 49 AM

Screen Shot 2021-02-25 at 11 51 53 AM

Screen Shot 2021-02-25 at 11 52 31 AM


SCENARIO 2

- Their is an issue for users who used a TREZOR PASSPHRASE as a 13th or 25th word on their 12 word or 24 word seed phrase. This actually changes the address completely. Please see the Trezor documentation here https://blog.trezor.io/seed-pin-passphrase-e15d14a0b546

- When restoring the wallet and adding the Trezor Passphrase I no longer get the same wallet address. This means that when I open the v3 wallet with my Trezor and a Passphrase the address generated will be different from the address I would get if I just copy and pasted only my 12 word or 24 word seed phrase into the v4 wallet's textbox for the seed phrase as we have shown above.

Please see the images below for more description.

Screen Shot 2021-02-25 at 12 06 42 PM

Screen Shot 2021-02-25 at 12 51 29 PM

Screen Shot 2021-02-25 at 12 09 36 PM

Screen Shot 2021-02-25 at 12 51 29 PM

Screen Shot 2021-02-25 at 12 35 03 PM

Screen Shot 2021-02-25 at 12 11 52 PM

@timstackblock timstackblock added the needs-validation Bug requires Stacks Wallet team verification label Feb 24, 2021
@timstackblock timstackblock self-assigned this Feb 24, 2021
@stackatron
Copy link

Thanks @timstackblock

Also context what happens when I try to enter 12, 13, or 26 words into v4? An error in all cases? Could it take those inputs in theory to generate the correct address? @kyranjamie

@timstackblock
Copy link
Author

It doesn't error as long as we go over the 12 or 24 word expected input. If I enter 13 or 25 words it ignores the last word and it just opens the 12 word or 24 word seed phrase wallet.

@timstackblock
Copy link
Author

Basically we never planned for that input so it doesn't recognize it.

@timstackblock
Copy link
Author

@markmhx @andresgalante this is kind of a big deal we should try to get this into a sprint

@timstackblock timstackblock added the Enhancement 💡 Functionality needed or wanted by users label Feb 25, 2021
@markmhendrickson markmhendrickson added Bug 🐛 Functionality broken P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds labels Feb 26, 2021
@markmhendrickson markmhendrickson changed the title Document how a 12 word seed phrase could have been used in the V3 wallet Support Secret Key values with passphrase addition (e.g. 13-word, 25-word) Feb 26, 2021
@markmhendrickson
Copy link
Collaborator

It's indeed important to support 13-word, 25-word etc phrases here without treating them as 12, 24, etc.

@jeffdomke to be clear, though, you were wondering if key values entered strictly as 12 words could be interpreted differently in the new wallet vs. the old, correct? Or is it possible that you had this sort of passphrase scenario in mind as well?

@kyranjamie
Copy link
Collaborator

I suggest we just include a non-valid bip39 option you can enable, off by default

@GinaAbrams
Copy link

Came here to share from forum user Bruce:

Tip:
The Stacks Wallet can be used with only 12 and 24-word Secret Keys

Can you provide a tool like this?
https://iancoleman.io/bip39/#english

@stackatron
Copy link

@markmhx I wasn't suggesting a feature or type of support. I was wondering if the following is happening:

  • User has 13 word seed created with Trezor
  • User enters 13 words into software wallet
  • Wallet correctly uses first 12 words to generate keypair
  • User sees empty wallet address and then reports a problem to us

Does this happen or does error out?

@markmhendrickson
Copy link
Collaborator

That appears to be the behavior @timstackblock reports here when 13 words are entered, in that it does not error out.

By "you were wondering", I mean the other week when you asked us about this during a sync. IIRC you were inquiring about users entering 12 words into the new wallet and whether they could end up with different addresses than with the old wallet. But I just wanted to confirm whether that was actually the same concern as the bug found here with 13 words.

@kyranjamie
Copy link
Collaborator

@jeffdomke This does not happen, it'll will error out as it's not a valid phrase

image

@markmhendrickson
Copy link
Collaborator

I'm confused about this comment then? 🤔 #641 (comment)

@0x20bf
Copy link

0x20bf commented Feb 27, 2021

Now the question is:
There are users who used "trezor+passphrase" in the old wallet. In the new Stacks wallet, they are unable to restore their accounts using "24 words+passphrase".

I suggest to fix this issue as soon as possible, otherwise some users will not be able to get their crypto assets back.

@markmhendrickson
Copy link
Collaborator

@0x20bf That's true it's important to fix this issue soon. Note, however, that meanwhile Trezor users should be able to migrate to Ledger for access to their crypto. This seems to affect entering Secret Key values directly only.

@kyranjamie
Copy link
Collaborator

kyranjamie commented Feb 27, 2021

I'm confused about this comment then? 🤔 #641 (comment)

Screenshot

image

Tested with 13 words too. @timstackblock can you elaborate, where did you see it ignoring the last word?

@0x20bf
Copy link

0x20bf commented Feb 27, 2021

@0x20bf That's true it's important to fix this issue soon. Note, however, that meanwhile Trezor users should be able to migrate to Ledger for access to their crypto. This seems to affect entering Secret Key values directly only.

  1. Trezor's "24 words+passphrase" cannot be restored to the Ledger wallet.
    2, about Stacks wallet, there are two possible solution paths.
    a. Enter "12/24 words+passphrase" to recover the wallet.
    b. Enter a private key to recover an account.

@markmhendrickson
Copy link
Collaborator

Is the Trezor passphrase not compatible for conversion into a Ledger passphrase along with the underlying seed phrase?

It seems they should be compatible, though I haven't tested it myself:

https://veriphi.io/en/blog/passphrase-tutorial
https://support.ledger.com/hc/en-us/articles/115005214529-Advanced-passphrase-security

@markmhendrickson markmhendrickson changed the title Support Secret Key values with passphrase addition (e.g. 13-word, 25-word) Provide guidance for migrating Trezor passphrase to Ledger Mar 2, 2021
@markmhendrickson markmhendrickson removed P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds Bug 🐛 Functionality broken needs-validation Bug requires Stacks Wallet team verification labels Mar 2, 2021
@markmhendrickson markmhendrickson changed the title Provide guidance for migrating Trezor passphrase to Ledger Add link to FAQ for word-length error message upon Secret Key entry Mar 2, 2021
@markmhendrickson markmhendrickson changed the title Add link to FAQ for word-length error message upon Secret Key entry Add link to FAQ for words-length error message upon Secret Key entry Mar 2, 2021
@markmhendrickson
Copy link
Collaborator

After discussing this as a team, we've decided to provide clearer guidance for Trezor users with passphrases for migrating to Ledger with their passphrases and not to support the entry of these passphrases directly into the wallet somehow without a hardware device.

I've modified this issue title accordingly. It's new aim should be to add simply a "Learn more" link to the end of the error message The Stacks Wallet can be used with only 12 and 24-word Secret Keys, which uses the following URL:

https://www.hiro.so/questions/what-are-secret-keys-and-how-do-they-work#12%20vs.%2024-word%20Secret%20Keys

Users can find generic information there about both words length as well as specific guidance for Ledger and Trezor users with passphrases.

kyranjamie added a commit that referenced this issue Mar 15, 2021
blockstack-devops pushed a commit that referenced this issue Mar 16, 2021
## [4.1.1](v4.1.0...v4.1.1) (2021-03-16)

### Bug Fixes

* add until-burn-ht arg to delegation form, closes [#651](#651) ([1bc104d](1bc104d))
* address not displayed at same time as ledger, closes [#548](#548) ([e651890](e651890))
* bip39 error, closes [#641](#641) ([24231bc](24231bc))
* stacking card handling of stacking & no funds, closes [#664](#664) ([391239f](391239f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💡 Functionality needed or wanted by users
Projects
None yet
Development

No branches or pull requests

6 participants