-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to FAQ for words-length error message upon Secret Key entry #641
Comments
Thanks @timstackblock Also context what happens when I try to enter 12, 13, or 26 words into v4? An error in all cases? Could it take those inputs in theory to generate the correct address? @kyranjamie |
It doesn't error as long as we go over the 12 or 24 word expected input. If I enter 13 or 25 words it ignores the last word and it just opens the 12 word or 24 word seed phrase wallet. |
Basically we never planned for that input so it doesn't recognize it. |
@markmhx @andresgalante this is kind of a big deal we should try to get this into a sprint |
It's indeed important to support 13-word, 25-word etc phrases here without treating them as 12, 24, etc. @jeffdomke to be clear, though, you were wondering if key values entered strictly as 12 words could be interpreted differently in the new wallet vs. the old, correct? Or is it possible that you had this sort of passphrase scenario in mind as well? |
I suggest we just include a non-valid bip39 option you can enable, off by default |
Came here to share from forum user Bruce: Tip: Can you provide a tool like this? |
@markmhx I wasn't suggesting a feature or type of support. I was wondering if the following is happening:
Does this happen or does error out? |
That appears to be the behavior @timstackblock reports here when 13 words are entered, in that it does not error out. By "you were wondering", I mean the other week when you asked us about this during a sync. IIRC you were inquiring about users entering 12 words into the new wallet and whether they could end up with different addresses than with the old wallet. But I just wanted to confirm whether that was actually the same concern as the bug found here with 13 words. |
I'm confused about this comment then? 🤔 #641 (comment) |
Now the question is: I suggest to fix this issue as soon as possible, otherwise some users will not be able to get their crypto assets back. |
@0x20bf That's true it's important to fix this issue soon. Note, however, that meanwhile Trezor users should be able to migrate to Ledger for access to their crypto. This seems to affect entering Secret Key values directly only. |
Tested with 13 words too. @timstackblock can you elaborate, where did you see it ignoring the last word? |
|
Is the Trezor passphrase not compatible for conversion into a Ledger passphrase along with the underlying seed phrase? It seems they should be compatible, though I haven't tested it myself: https://veriphi.io/en/blog/passphrase-tutorial |
After discussing this as a team, we've decided to provide clearer guidance for Trezor users with passphrases for migrating to Ledger with their passphrases and not to support the entry of these passphrases directly into the wallet somehow without a hardware device. I've modified this issue title accordingly. It's new aim should be to add simply a "Learn more" link to the end of the error message Users can find generic information there about both words length as well as specific guidance for Ledger and Trezor users with passphrases. |
## [4.1.1](v4.1.0...v4.1.1) (2021-03-16) ### Bug Fixes * add until-burn-ht arg to delegation form, closes [#651](#651) ([1bc104d](1bc104d)) * address not displayed at same time as ledger, closes [#548](#548) ([e651890](e651890)) * bip39 error, closes [#641](#641) ([24231bc](24231bc)) * stacking card handling of stacking & no funds, closes [#664](#664) ([391239f](391239f))
SCENARIO 1
- If you have a Trezor with a 12 word or 24 word seed phrase you can easily use the same seed phrase in the old wallet (via your trezor) and in the new wallet by entering the seed phrase into the seed phrase input box.
- Below you see me entering the 12 word seed phrase from my Trezor into the new v4 wallet and it opening to the same address that I get when accessing the v3 wallet with my Trezor.
- There is absolutely no issue and the migration from the old wallet to the new wallet is seamless.
SCENARIO 2
- Their is an issue for users who used a TREZOR PASSPHRASE as a 13th or 25th word on their 12 word or 24 word seed phrase. This actually changes the address completely. Please see the Trezor documentation here https://blog.trezor.io/seed-pin-passphrase-e15d14a0b546
- When restoring the wallet and adding the Trezor Passphrase I no longer get the same wallet address. This means that when I open the v3 wallet with my Trezor and a Passphrase the address generated will be different from the address I would get if I just copy and pasted only my 12 word or 24 word seed phrase into the v4 wallet's textbox for the seed phrase as we have shown above.
Please see the images below for more description.
The text was updated successfully, but these errors were encountered: