Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTNET_BUG] trait_reference not supported as function parameter type #872

Closed
friedger opened this issue Dec 2, 2020 · 0 comments · Fixed by #873
Closed

[TESTNET_BUG] trait_reference not supported as function parameter type #872

friedger opened this issue Dec 2, 2020 · 0 comments · Fixed by #873
Labels
bug Unwanted or unintended logic causing harm

Comments

@friedger
Copy link
Collaborator

friedger commented Dec 2, 2020

Describe the bug
It is not possible to call a function in the explorer that contains a parameter of trait_reference type

What version of Blockstack.js are you using?
stacks.js 1.0.0-beta.12
and master branch

Is the bug present in the Blockstack CLI, Gaia hub, Connect or Blockstack Browser?
Testnet explorer

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://testnet-explorer.blockstack.org/txid/ST3YPJ6BBCZCMH71TV8BK50YC6QJTWEGCNDFWEQ15.advent-calendar
  2. Copy contract name
  3. Navigate to sandbox -> contract call and past contract
  4. try to call "open-door" with "2" and "ST12EY99GS4YKP0CP2CFW6SEPWQ2CGVRWK5GHKDRV.calendar-02"
  5. See that connect shows an error

Screenshot from 2020-12-01 22-49-58

Expected behavior
Contract call should be executed

Additional context
Contract interface:
https://stacks-node-api.blockstack.org/v2/contracts/interface/ST3YPJ6BBCZCMH71TV8BK50YC6QJTWEGCNDFWEQ15/advent-calendar

Relevant code:
https://github.com/blockstack/blockstack.js/blob/86829fe5eadbbe3fe1345234567b1d10e88c1b5b/packages%2Ftransactions%2Fsrc%2Fcontract-abi.ts#L53
@friedger friedger mentioned this issue Dec 2, 2020
Merged
9 tasks
@markmhendrickson markmhendrickson added the bug Unwanted or unintended logic causing harm label Dec 3, 2020
@yknl yknl linked a pull request Dec 7, 2020 that will close this issue
fix(transactions): add handling of trait_reference #873
Merged
9 tasks
@yknl yknl added this to In review in Splat Team Dec 7, 2020
@yknl yknl closed this as completed in #873 Dec 9, 2020
@project-bot project-bot bot moved this from In review to Done in Splat Team Dec 9, 2020
@friedger friedger mentioned this issue Dec 18, 2020
Closed
@CharlieC3 CharlieC3 removed this from 🚀 Done in Splat Team Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unwanted or unintended logic causing harm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(transactions): add handling of trait_reference friedger/stacks.js
2 participants
@markmhendrickson @friedger