Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email-friendly image attribute to apps feed #2

Closed
markmhendrickson opened this issue Jan 15, 2019 · 1 comment
Closed

Add email-friendly image attribute to apps feed #2

markmhendrickson opened this issue Jan 15, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@markmhendrickson
Copy link

To ensure that all images are provided as PNG through that attribute since @cuevasm is using a mailer that doesn't support SVG.

Please notify @cuevasm once this attribute is live so he can switch his mailer to using it.

@markmhendrickson markmhendrickson added the enhancement New feature or request label Jan 15, 2019
@hstove
Copy link
Contributor

hstove commented Jan 28, 2019

@cuevasm this was fixed in the commit a986ab9. We actually fixed SVG format, so most email clients would work now, but some still don't support SVG.

I changed the RSS feed to always include the PNG format of the image. There are no changes required on your end.

@hstove hstove closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants