Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active parameter in the list_* calls is not intuitive #66

Closed
emre opened this issue Mar 12, 2019 · 2 comments
Closed

active parameter in the list_* calls is not intuitive #66

emre opened this issue Mar 12, 2019 · 2 comments
Assignees
Labels
in progress Work in progress

Comments

@emre
Copy link

emre commented Mar 12, 2019

in the SPS API Plugin list_proposals and list_voter_proposals have a parameter named active where one can pass 1, 0, or -1. It sounds like a boolean field by its naming, however, it's not.

Instead of that I propose to change that parameter's name to the status where options can be String.

  • active
  • inactive
  • all
@bwsdeveloper
Copy link

I like this idea, enum values are much more readable.

@bwsdeveloper
Copy link

Merged:
2e5779b
#71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Work in progress
Projects
None yet
Development

No branches or pull requests

3 participants