Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block based timeouts #89

Merged
merged 11 commits into from
May 16, 2022
Merged

block based timeouts #89

merged 11 commits into from
May 16, 2022

Conversation

abrzezinski94
Copy link
Contributor

No description provided.

@abrzezinski94
Copy link
Contributor Author

i made block optional in sendSignedTransaction so there is still option to use old timeout based on time so people dont need to adjust it after new npm version. To use block based timeout you need to fetch getLatestBlockHash before wallet sign and pass block to sendSignedTransaction.

Copy link

@carnesen carnesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a maintainer of this repo, just a user. So please take all my comments with a grain of salt and know that in the end I can't merge it in either case.

src/utils/utils.ts Outdated Show resolved Hide resolved
src/utils/utils.ts Outdated Show resolved Hide resolved
src/utils/utils.ts Outdated Show resolved Hide resolved
src/utils/utils.ts Show resolved Hide resolved
src/utils/utils.ts Outdated Show resolved Hide resolved
src/utils/utils.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@abrzezinski94 abrzezinski94 merged commit 51c939c into main May 16, 2022
pan0ply added a commit to Merstab/mango-client-v3 that referenced this pull request Jun 10, 2022
* Add code examples for docs

* Added new 'account11' health tests. Added more expect clauses for perp values and redeemable pnl to allow other clients to use them as reference values. (blockworks-foundation#71)

Co-authored-by: Geoff Taylor <geoff@dev.opgeek.lan>
Co-authored-by: tjshipe <tjshipe@gmail.com>

* Updates wallet adapter type to be nullable

* Updates TS version

* Adds nullable checks for adapter

* Updates settlePosPnl return type

* use default values

* fix keypairs

* v3.4.0

* increase send tx retries

* v3.4.1

* support custom timeout option in client constructor

* v3.4.2

* bump up tx confirmation retry sleep

* allow to configure dedicated send connection

* v3.4.3

* add liq. price to yarn cli show command

* positions script fetches by OI

* Fixes unspecific imports

* reduce client timeout to 10s in keeper

* fix timeout mechanism for keeper

* v3.4.4

* Fix TestGroup

* Added TxIx check to emptyAndCloseMangoAccount

Added a check to verify that redeemMngoTransaction transaction instructions length is greater than 0

* Default to one hour possible delay on orderbook timestamp. Effectively nullifies the feature and just uses maxTimestamp

* v3.4.5

* fix: Keypair

* use zero keys for open orders accounts where necessary in liquidate functions

* v3.4.6

* block based timeouts (blockworks-foundation#89)

* block based timeouts

* remove unnes let

* rename block to signedAtBlock

* promise to promise all

* suggestion fixes

* remove export

* import MAXIMUM_NUMBER_OF_BLOCKS_FOR_TRANSACTION from utils for client.ts

* fix variable naming

* GetLatestBlockhashType to LatestBlockhash

* use both connection in send transaction

* remove null check in tryGetlatestBlock connection

* v3.4.7

* remove double blockhash fetch

* rename

* v3.4.8

* Upgrade solana/web3.js to 1.42.0

* Fix cache key

* Update lockfile

* add spot balance sorting

* upgrade web3

* add benchmarks

* update lock file

* mark mango cache and rootbank as writable in deposit instruction

* add GMT ids

* v3.5.0

* use sane tx send and confirm retry numbers; remove deprecated code

* v3.5.1

* add back lastSlot tracking for ui

* v3.5.2

* use latest web3.js patch v

* v3.5.3

* calculate net exposure (blockworks-foundation#97)

* calculate net exposure

* remove unneeded import

* correct calculation

* release v3.5.4

* increase max retries to retry for up to 60secs

* v3.5.5

* adding CancelAllSpotOrders instruction into the lib (blockworks-foundation#79)

* adding CancelAllSpotOrders instruction into the lib

* adding test to test cancelallspotorders

* correcting tests for cancelallspotorders

* adding new yarn script to launch cancelallspotorders test

* cancelallspotorders test changes after max's review.

* moving pyth-client from dependencies to dev-dependecies

Co-authored-by: Riordan Panayides <riordan@panayid.es>
Co-authored-by: Geoff Taylor <github@opinionatedgeek.com>
Co-authored-by: Geoff Taylor <geoff@dev.opgeek.lan>
Co-authored-by: tjshipe <tjshipe@gmail.com>
Co-authored-by: Kieran Gillen <kgillen@gmail.com>
Co-authored-by: Maximilian Schneider <mail@maximilianschneider.net>
Co-authored-by: dafyddd <daffy321@gmail.com>
Co-authored-by: abacus-x <79712764+abacus-x@users.noreply.github.com>
Co-authored-by: Börkur I. Jónsson <borkur@logko.is>
Co-authored-by: Adrian Brzeziński <a.brzezinski94@gmail.com>
Co-authored-by: godmodegalactus <96341601+godmodegalactus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants