-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/master applications rate limit #1103
Conversation
Update .env.temnplate and backend readme
Deploy preview for clever-edison-cd22c1 ready! Built with commit 25b7b62 https://deploy-preview-1103--clever-edison-cd22c1.netlify.app |
ThrottlerModule.forRoot({ | ||
ttl: 60, | ||
limit: 5, | ||
ignoreUserAgents: [/^node-superagent.*$/], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ignore node-superagent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This agent is used by all tests. Without this all tests hits rate limit and fails. Note that the test for rate limits i added in this PR is forcing different agent. Also note that this ignore setting is added only in tests spec, and not in actual app.
@@ -1,6 +1,7 @@ | |||
PORT=3100 | |||
NODE_ENV=development | |||
DATABASE_URL=postgres://bloom-dev:CHANGE-ME@localhost:5432/bloom | |||
REDIS_URL=redis://127.0.0.1:6379/0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that Heroku added two URLs to the container config for Redis and one of them is SSL, so I think the connection to redis will be over a public internet and we should use SSL in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pbn4 redis over TLS applied.
Thanks for handling redis on CI
This is temp dirty fix that force jest to exit even with open handle. It fix only the effects, not reasons. Better fix needed
resolves: #889