Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/master applications rate limit #1103

Merged
merged 17 commits into from
Apr 15, 2021

Conversation

bpsushi
Copy link
Collaborator

@bpsushi bpsushi commented Apr 6, 2021

resolves: #889

@bpsushi bpsushi requested a review from pbn4 April 6, 2021 10:46
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-c04u86 April 6, 2021 10:46 Inactive
@netlify
Copy link

netlify bot commented Apr 6, 2021

Deploy preview for clever-edison-cd22c1 ready!

Built with commit 25b7b62

https://deploy-preview-1103--clever-edison-cd22c1.netlify.app

ThrottlerModule.forRoot({
ttl: 60,
limit: 5,
ignoreUserAgents: [/^node-superagent.*$/],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ignore node-superagent?

Copy link
Collaborator Author

@bpsushi bpsushi Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This agent is used by all tests. Without this all tests hits rate limit and fails. Note that the test for rate limits i added in this PR is forcing different agent. Also note that this ignore setting is added only in tests spec, and not in actual app.

@@ -1,6 +1,7 @@
PORT=3100
NODE_ENV=development
DATABASE_URL=postgres://bloom-dev:CHANGE-ME@localhost:5432/bloom
REDIS_URL=redis://127.0.0.1:6379/0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that Heroku added two URLs to the container config for Redis and one of them is SSL, so I think the connection to redis will be over a public internet and we should use SSL in that case.

Copy link
Collaborator Author

@bpsushi bpsushi Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbn4 redis over TLS applied.

Thanks for handling redis on CI

@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-ppe8rf April 9, 2021 08:36 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-itziuw April 9, 2021 08:59 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-cauera April 9, 2021 09:00 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-7apzc0 April 12, 2021 14:28 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-tpnvqt April 12, 2021 14:50 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-xtgjau April 12, 2021 15:46 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-qcxlwj April 12, 2021 15:55 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-xxxn3g April 12, 2021 18:32 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-j4hrin April 14, 2021 08:52 Inactive
This is temp dirty fix that force jest to exit even with open handle. It fix only the effects, not reasons. Better fix needed
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-6etjrm April 14, 2021 12:08 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-4m5api April 14, 2021 18:14 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-8dawal April 15, 2021 08:38 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ma-vnffi7 April 15, 2021 08:46 Inactive
@pbn4 pbn4 merged commit 8cd4d1b into master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rate limiting to POST /applications/submit
4 participants