A preferredUnit property should stores unit type IDs

[dominikx96]

@pbn4 @seanmalbert
I've noticed a problem with the preferredUnit property which stores strings like: oneBedroom, twoBedroom etc.
It should stores unitType IDs instead of names especially that in the listings management we use unit names like: oneBdrm, twoBdrm - so it's a different format than in the preferredUnit.

Noticed it after working on #1768.

Partners / public application:

preferredUnit: ["oneBedroom"]

Listings management:

{
  "units": [
    {
      "unitType": {
        "createdAt": "2021-08-30T07:19:03.325Z"
        "id": "ec517815-5c30-4455-a28f-e52acbfdf031"
        "name": "oneBdrm"
        "numBedrooms": 1
      }
    }
  ]
}

Backend and frontend changes are needed.

[seanmalbert]

@dominikx96 , can you please write up QA instructions for this. I'll move it over to ready for QA.

[dominikx96]

@slowbot

1. Create a new listing with a few unit types e.g studio, 1 bedroom
2. Create a new application in partners and pick one of the options from the Preferred Unit Sizes section
3. Save and make sure that the application includes selected data
4. Create a new application in public following the rules below

[slowbot]

@dominikx96 Is there a time lag? I specified units units in partners listings management but they are not showing on the paper app form

Also seeing a bug on the front end of public

https://dev-bloom.netlify.app/listing/5c2851ab-0546-417d-a5d9-0629748b886b/my_test_unit_listing

[dominikx96]

@slowbot I see this listing does not exist on the dev, so I can't look at this. But I've seen it a few days ago and noticed a lack of filled unit types in the listings management - so that's the reason why it doesn't show in paper app form / public view. Can you test this using available listing by adding/removing some items from the Listing Units section?

The current dev version doesn't include listing management validation so probably that's the reason why you are able to save unit type with empty unit type.

Selected items were empty:

[slowbot]

Unit Type getting wiped out when I save as draft initially

[dominikx96]

@slowbot good catch, I've created a new issue to cover this bug: #1897
I'll let you know when I fix it.

[seanmalbert]

@slowbot , #1897 is now also in QA, so you should be able to follow up on this.