-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A preferredUnit property should stores unit type IDs #1774
Comments
@dominikx96 , can you please write up QA instructions for this. I'll move it over to ready for QA. |
|
@dominikx96 Is there a time lag? I specified units units in partners listings management but they are not showing on the paper app form Also seeing a bug on the front end of public https://dev-bloom.netlify.app/listing/5c2851ab-0546-417d-a5d9-0629748b886b/my_test_unit_listing |
@slowbot I see this listing does not exist on the dev, so I can't look at this. But I've seen it a few days ago and noticed a lack of filled unit types in the listings management - so that's the reason why it doesn't show in paper app form / public view. Can you test this using available listing by adding/removing some items from the Listing Units section? The current dev version doesn't include listing management validation so probably that's the reason why you are able to save unit type with empty unit type. |
@pbn4 @seanmalbert
I've noticed a problem with the
preferredUnit
property which stores strings like:oneBedroom
,twoBedroom
etc.It should stores
unitType
IDs instead of names especially that in the listings management we use unit names like:oneBdrm
,twoBdrm
- so it's a different format than in thepreferredUnit
.Noticed it after working on #1768.
Partners / public application:
Listings management:
Backend and frontend changes are needed.
The text was updated successfully, but these errors were encountered: