perf tester: Count messages/handle channel close/listen backlog #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed in a packet capture that we were sending two messages when it should only send one.
Noticed during testing that amiquip was sending Channel Close but the server send Channel OpenOk in return, triggering an error. Since this happened while the connection was being Drop'ed the error seems to have been swallowed. The connection close is now explicit, even though this does avoid closing the channel. I left in the channel close -> closeok in case we change something here in future.
Chinmay1412
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #69 I found a few issues with the perf tester:
FINfirst most of the time. I feel like the amqp library should probably ignore this case, but I'm also not sure how amqpprox handles this either so I probably can't be too upset - we do log a lot when connection are closing.