Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Add gen_keys.sh for generating ssl key and certificate for test server #126

Merged
merged 1 commit into from
Mar 10, 2015

Conversation

ericlu88
Copy link
Contributor

@ericlu88 ericlu88 commented Mar 9, 2015

This PR adds a bash script for generating ssl ca, server certificate and client certificate. It would be useful for both development and testing purpose.

This addresses #17

@ericvw
Copy link
Contributor

ericvw commented Mar 9, 2015

I know we the other directories are singular, but many projects pluralize script (i.e., scripts).

@@ -0,0 +1,32 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#! /usr/bin/env bash

@ericvw
Copy link
Contributor

ericvw commented Mar 10, 2015

lgtm

@ericvw ericvw changed the title Add GenKey.sh for generating ssl key and certificate for test server Add gen_keys.sh for generating ssl key and certificate for test server Mar 10, 2015
@ericvw
Copy link
Contributor

ericvw commented Mar 10, 2015

Actually, update the commit message to be gen_keys.sh to match the file name. Then lgtm :D

@ericlu88
Copy link
Contributor Author

Will appreciate another eye before we could merge it. @yupinghu @thmiceli

@thmiceli
Copy link
Contributor

LGTM

thmiceli added a commit that referenced this pull request Mar 10, 2015
Add gen_keys.sh for generating ssl key and certificate for test server
@thmiceli thmiceli merged commit 710be88 into bloomberg:develop Mar 10, 2015
@ericlu88 ericlu88 deleted the ssl-script branch March 10, 2015 18:32
thmiceli added a commit that referenced this pull request Mar 10, 2015
Add gen_keys.sh for generating ssl key and certificate for test server
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants