Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on a #notebook element existing #382

Closed
jasongrout opened this issue Dec 6, 2016 · 3 comments
Closed

Don't depend on a #notebook element existing #382

jasongrout opened this issue Dec 6, 2016 · 3 comments

Comments

@jasongrout
Copy link
Member

In the two show_tooltip methods:

https://github.com/bloomberg/bqplot/blob/3dd09694fce17841787bcb0a26b21079d62ee167/js/src/MarketMap.js#L604

https://github.com/bloomberg/bqplot/blob/e3501c367af3f91559d702896ec49ba73189a614/js/src/Mark.js#L250

there are references to the #notebook document element. This may not exist (embedded plots, or in JLab, etc.). We should not depend on DOM structure like this.

@jasongrout jasongrout changed the title Don't depend on #notebook existing Don't depend on a #notebook element existing Dec 6, 2016
@dmadeka
Copy link
Contributor

dmadeka commented Dec 21, 2016

@jasongrout do you think we could use this.el there instead?

@ssunkara1
Copy link
Contributor

As of the last time I checked, I could not find any other way of getting the tooltip positioning to be correct when we scroll (horizontally (there are two types of this. 1. When the entire browser window is scrollable. 2. When only the widget output area is scrollable) and vertically)/full screen etc. Depending on the #notebook element was a temporary fix to the problem as I discussed with @jasongrout at the time I was making that change. We do need to figure out a better way of doing it.

@ssunkara1
Copy link
Contributor

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants