avoid lock inversion during partition rollout #4365
Conversation
…g triggers update. Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
There was a problem hiding this comment.
Lint check:
@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.
@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.
@@ berkdb/db/trigger_subscription.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ berkdb/env/env_method.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ db/reqlog.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ plugins/reversesql/reversesql.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ plugins/reversesql/reversesql.c @@
+ Please replace any pthread_xxx() function in your diff with corresponding Pthread_xxx() wrapper.
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/523 tests failed ⚠.
The first 10 failing tests are:
sc_transactional_rowlocks_generated
truncatesc_offline_generated
pmux_sqlite_file_generated
tunables
sc_lotsoftables_logicalsc_generated
sc_lotsoftables
sc_downgrade
truncatesc
There was a problem hiding this comment.
Lint check:
@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.
@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.
@@ berkdb/db/trigger_subscription.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ berkdb/env/env_method.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ db/reqlog.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ plugins/reversesql/reversesql.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ plugins/reversesql/reversesql.c @@
+ Please replace any pthread_xxx() function in your diff with corresponding Pthread_xxx() wrapper.
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 7/523 tests failed ⚠.
The first 10 failing tests are:
sc_truncate
truncatesc_offline_generated
queuedb_rollover
sc_timepart_logicalsc_generated
tunables
sc_downgrade
selectv_rcode_disable_svonly_nop_generated
|
cdb2test Apr 18 14:00:13 2024 in-comdb2db fix_lock_inversion_partitions.R20240418.6 |
|
@mponomar thank you |
Short fix for partition lock inversion: do not read from llmeta during triggers update.
Re: 174791652