Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resubmit https://github.com/bloomberg/comdb2/pull/4367 with shorter branch name #4457

Merged
merged 1 commit into from
May 31, 2024
Merged

Resubmit https://github.com/bloomberg/comdb2/pull/4367 with shorter branch name #4457

merged 1 commit into from
May 31, 2024

Conversation

dorinhogea
Copy link
Contributor

Breaks rm.

From the original PR:

3 things:

  • avoid reading llmeta during views update (lock inversion prevention) (ported avoid lock inversion during partition rollout #4365 to main)
  • remove code and tunable sc_done_same_tran (only on going forward)
  • fix scdone for comdb2sc and partition rollouts, where it is sent outside finalizing txn

@dorinhogea dorinhogea mentioned this pull request May 28, 2024
Closed
roborivers
roborivers suggested changes May 28, 2024
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/534 tests failed ⚠.

The first 10 failing tests are:
logfill
sc_downgrade
sc_lotsoftables
truncatesc_offline_generated

@dorinhogea
Copy link
Contributor Author

cdb2test May 28 15:28:41 2024 in-comdb2db fixlockinversion_partitionsm.R20240528.3

@dorinhogea
3 things:
acc3c8c 
avoid reading llmeta during views update (lock inversion prevention)
remove code and tunable sc_done_same_tran (only on going forward)
fix scdone for comdb2sc and partition rollouts, where it is sent outside finalizing txn

Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
@dorinhogea dorinhogea force-pushed the fixlockinversion_partitionsm branch from f3fc827 to acc3c8c Compare May 29, 2024 17:37
@dorinhogea
Copy link
Contributor Author

cdb2test May 30 10:55:19 2024 in-comdb2db fixlockinversion_partitionsm.R20240530.1

@dorinhogea
Copy link
Contributor Author

@mponomar thank you

@dorinhogea dorinhogea merged commit a160964 into bloomberg:main May 31, 2024
1 check passed
@dorinhogea dorinhogea deleted the fixlockinversion_partitionsm branch May 31, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roborivers roborivers roborivers requested changes

@mponomar mponomar mponomar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dorinhogea @mponomar @roborivers