Make rebuild work for partitions that are created using "create .. partitioned" syntax. #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
suggested changes
May 7, 2024
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/532 tests failed ⚠.
The first 10 failing tests are:
schemalk
sc_transactional_rowlocks_generated
sc_downgrade
truncatesc_offline_generated
truncatesc_ufid_on_generated
comdb2sys
comdb2sys_pagesize_generated
comdb2sys_queueodh_generated
chands10
reviewed
May 16, 2024
dorinhogea
force-pushed
the
fix_rebuild_partition
branch
from
80cd125
to
5237270
Compare
…rtitioned" syntax. Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
dorinhogea
force-pushed
the
fix_rebuild_partition
branch
from
5237270
to
a8d78da
Compare
|
cdb2test May 28 17:50:28 2024 in-comdb2db fix_rebuild_partition.R20240528.4 |
mponomar
approved these changes
May 29, 2024
|
@mponomar thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple patch, use one shard to retrieve csc2 and make rebuild work.
NOTE: rebuild work for partitions added to existing tables, because first tables are aliased and share the same name as the partition.