Skip to content

Commit

Permalink
Vendor the correct liblz4 into macOS wheels
Browse files Browse the repository at this point in the history
We were previously setting `DYLD_LIBRARY_PATH`, but macOS's System
Integrity Protections were resulting in that environment being dropped
before `delocate` was run, causing an incorrect version of `liblz4` to
be found and vendored.

See pypa/cibuildwheel#816

Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
  • Loading branch information
godlygeek committed May 13, 2024
1 parent 133347e commit 4a9203c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ jobs:
CIBW_BUILD_VERBOSITY: 1
CFLAGS: "${{env.CFLAGS}} -I${{env.LZ4_INSTALL_DIR}}/include"
LDFLAGS: "-L${{env.LZ4_INSTALL_DIR}}/lib -Wl,-rpath,${{env.LZ4_INSTALL_DIR}}/lib"
DYLD_LIBRARY_PATH: "${{env.LZ4_INSTALL_DIR}}/lib"
PKG_CONFIG_PATH: "${{env.LZ4_INSTALL_DIR}}/lib/pkgconfig"
- uses: actions/upload-artifact@v4
with:
name: macosx_${{ matrix.arch }}-wheels
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ before-all = [
"git clone --depth 1 --branch v1.9.4 https://github.com/lz4/lz4 lz4",
"cd lz4",
"make",
"make install PREFIX=$LZ4_INSTALL_DIR"
"make install PREFIX=$LZ4_INSTALL_DIR",
"find $LZ4_INSTALL_DIR",
]
before-test = [
"codesign --remove-signature /Library/Frameworks/Python.framework/Versions/*/bin/python3 || true",
Expand Down

0 comments on commit 4a9203c

Please sign in to comment.